facet_wrap(drop = TRUE)
can handle character variables with NA
s
#5847
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #5485.
Briefly,
ulevels()
was always droppingNA
s, leading to data being mapped to non-existing PANELs and generating invalidscale_id
s. By includingNA
s, we prevent these invalidscale_id
s.stat_summary_2d()
was also making use ofulevels()
whereNA
s should be dropped. Therefore,ulevels()
gets anna.last
argument that is propagated tosort()
so we can pick when to dropNA
and when not.Reprex from issue:
Created on 2024-04-18 with reprex v2.1.0